This repository has been archived by the owner on Aug 24, 2024. It is now read-only.
Add initial micropub content and tag update support #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for attempting this... Would it be better to break this down into smaller parts, then? I can see that the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial attempt to add micropub update support.
It had clearly already been started/tried. I hooked up the update function but realised it literally just updates the content of the post, it doesn't update any associated objects. I added the logic for tags, and then realised there were other objects too.
The objects are all already created in send_create(), so rather than duplicating logic into a half complete send_update(), a better approach would be just to rewrite send_create to something like "send_change" which then can update or create depending on if the thing already exists. I did look into doing that, but it gets a little confusing in places.